Join Slack
Powered by
do we have a good PR example with a python integra...
# contributing-to-airbyte
m
Michel
11/02/2020, 10:58 PM
do we have a good PR example with a python integration written from scratch?
u
user
11/02/2020, 10:59 PM
maybe the rest api one? though maybe ruined since we are changing the name:
https://github.com/airbytehq/airbyte/pull/777
u
user
11/02/2020, 11:00 PM
all good
u
user
11/02/2020, 11:00 PM
the other from scratch ones are google sheets and csv file
u
user
11/02/2020, 11:00 PM
beside a rename, you don't have any subsequent PR right? It is completely self contained?
u
user
11/02/2020, 11:01 PM
yup as far i know of.
u
user
11/02/2020, 11:01 PM
jared made a good suggestion to make the stream name configurable in the config, but i think of that as an additional feature not a breaking change.
u
user
11/02/2020, 11:07 PM
whelp, i’m wrong. i didn’t add it in the index in SUMMARY.md 😭. disqualified.
u
user
11/02/2020, 11:07 PM
it is ok 🙂
2
Views
Open in Slack
Previous
Next