https://linen.dev logo
c

Chris (deprecated profile)

11/05/2020, 5:12 PM
@s could you please help looking at this PR? https://github.com/airbytehq/airbyte/pull/802 I've merged and pushed back the changes to put Charles' branches and mine together for the normalization process... However I've ran into a last stop block where i have to run with a bunch of excludes:
gradlew build -x spotlessSql -x spotlessSqlApply -x spotlessSqlCheck
to make it build successfully... (Spotless is messing up the DBT SQL code turning into syntax errors otherwise...) Thanks!
u

user

11/05/2020, 5:25 PM
looking
u

user

11/05/2020, 5:25 PM
We should exclude spotless from those dirs
u

user

11/05/2020, 5:26 PM
yeah can you add it as an exclude pattern in the root build.gradle?
u

user

11/05/2020, 5:28 PM
Could you teach me how? 🤔 do I need to write:
Copy code
gradle.startParameter.excludedTaskNames << "spotlessSql"
or something like that?
u

user

11/05/2020, 5:32 PM
in the root build.gradle file (in the airbyte project root) you’ll find a block of code that looks like this:
Copy code
spotless {
.
.
.
    sql {
        target '**/*.sql'
        targetExclude "**/build/**/*", "**/.gradle/**/*", "**/.venv/**"

        dbeaver().configFile(rootProject.file('tools/gradle/codestyle/sql-dbeaver.properties'))
    }
....
u

user

11/05/2020, 5:33 PM
so we’d just need to add a pattern under
targetExclude
for the
sql
block that ignores DBT sql files
u

user

11/05/2020, 11:56 PM
I hope your PR handles this case @Michel!!
u

user

11/05/2020, 11:57 PM
it doesn't, can you point me to the github directory where these files are?