https://linen.dev logo
j

Jared Rhizor (Airbyte)

12/09/2020, 6:52 PM
Would it make sense to bundle the
seed
contents into the
scheduler
?
u

user

12/09/2020, 6:53 PM
Since
depends_on
doesn’t do anything in docker-compose files version 3+ (and we’re on 3.7), it seems like we should be ensuring that the files are initialized properly as a dependency of the scheduler.
u

user

12/09/2020, 6:54 PM
Coordination between the two doesn’t seem to make a ton of sense to me, but I also don’t remember if there was a practical reason why we split out
seed
in the first place.
u

user

12/09/2020, 6:54 PM
What do you think @charles?
u

user

12/09/2020, 6:57 PM
both server and schedueler rely on seed.
u

user

12/09/2020, 6:57 PM
does that mess up what you just proposed?
u

user

12/09/2020, 6:58 PM
hmm
u

user

12/09/2020, 6:58 PM
kind of
u

user

12/09/2020, 6:58 PM
I mean the scheduler depends on the server to run before doing anything too
u

user

12/09/2020, 6:59 PM
Same implicit dependency, just on a different system
u

user

12/09/2020, 6:59 PM
Server instead of seed
u

user

12/09/2020, 7:02 PM
woof. this feels brittle to m.e
u

user

12/09/2020, 7:02 PM
it's hard for me to understand how they could have just not replaced dependson.
u

user

12/09/2020, 7:03 PM
From the kube perspective you run into the same problem.
u

user

12/09/2020, 7:03 PM
No depends on
u

user

12/09/2020, 7:03 PM
apps are responsible for their own connect/reconnect logic
u

user

12/09/2020, 7:03 PM
i see
u

user

12/09/2020, 7:03 PM
which is probably the same reasoning as docker-compose I imagine
u

user

12/09/2020, 7:04 PM
so can we just leave the seed container
u

user

12/09/2020, 7:04 PM
but then have anything that tries to connect to config respository fail / retry if it can't find the files it needs.
u

user

12/09/2020, 7:04 PM
seems like that's the pattern we're supposed to use?
u

user

12/09/2020, 7:04 PM
Yeah we can do that too.
u

user

12/09/2020, 7:04 PM
That seems fine
u

user

12/09/2020, 7:05 PM
And in kube we can do that as a one time job
u

user

12/09/2020, 7:05 PM
instead of a deployment
4 Views