https://linen.dev logo
j

Jared Rhizor (Airbyte)

01/14/2021, 10:06 PM
What do you think of these badges for connector build status?
u

user

01/14/2021, 10:06 PM
Is it clear what the colors and numbers mean @s and @charles?
u

user

01/14/2021, 10:07 PM
oooh. pretty.
u

user

01/14/2021, 10:07 PM
i actually don't think i know what yellow means.
u

user

01/14/2021, 10:07 PM
well
u

user

01/14/2021, 10:07 PM
Also what should we say if it’s not certified?
u

user

01/14/2021, 10:07 PM
just no message?
u

user

01/14/2021, 10:07 PM
i assume green means last build passed. red means last build failed. i don't know what yellow means.
u

user

01/14/2021, 10:07 PM
I was thinking yellow would be the most recent one passed but it has at least one failure in the last 10 builds
u

user

01/14/2021, 10:09 PM
i think i would just do green and red then. i think that's too nuanced.
u

user

01/14/2021, 10:09 PM
that or you need to explain it whereever these get posted.
u

user

01/14/2021, 10:10 PM
but it's not self evident (at least for me)
u

user

01/14/2021, 10:30 PM
I think I’ll document it. It isn’t self evident but it’ll make a dashboard more scannable
u

user

01/14/2021, 10:30 PM
👍
u

user

01/14/2021, 10:44 PM
the different categories are: Alpha, beta, Airbyte certified
u

user

01/14/2021, 10:45 PM
or actually, let’s just make an alpha, <blank>, and AB certified
u

user

01/14/2021, 10:47 PM
@s should we add that as a field to SourceDefinitions?
u

user

01/14/2021, 10:48 PM
I guess what is the ground truth of alpha/blank/certified?
u

user

01/14/2021, 10:50 PM
because this standard is centrally enforced managed, I’m having trouble thinking about how it would be displayed in the app itself
u

user

01/14/2021, 10:51 PM
I think the ground truth should be blank
u

user

01/14/2021, 10:52 PM
alpha/certified are modifiers we publish to give context imo
u

user

01/14/2021, 10:53 PM
sorry by ground truth
u

user

01/14/2021, 10:53 PM
I meant default value not ground truth
u

user

01/14/2021, 10:53 PM
I mean how/where the status of connectors is managed
u

user

01/14/2021, 10:53 PM
right
u

user

01/14/2021, 10:53 PM
Like should we add it to SourceDefinitoin and read it from there
u

user

01/14/2021, 10:53 PM
and `master`’s config files are used to determine certification
u

user

01/14/2021, 10:54 PM
That sounds good actually.
u

user

01/14/2021, 10:54 PM
Certainly better than having an endpoint to manage this stuff
u

user

01/14/2021, 10:54 PM
actually, there’s one problem with it
u

user

01/14/2021, 10:55 PM
if you update from an alpha to a certified version, it won’t update your instance
u

user

01/14/2021, 10:55 PM
hmm
u

user

01/14/2021, 10:55 PM
it’s probably tied to a specific version though
u

user

01/14/2021, 10:56 PM
oh but if you update it’s only through docker?
u

user

01/14/2021, 10:56 PM
not the config files on master
u

user

01/14/2021, 10:56 PM
I don’t think it makes sense to put it in the spec
u

user

01/14/2021, 10:56 PM
since we’re the only people that can make it airbyte certified
u

user

01/14/2021, 10:56 PM
I guess I’ll just add a separate file where we’ll track this.
u

user

01/14/2021, 10:57 PM
Or we could remove the certification from badging and purely handle it in documentation
u

user

01/14/2021, 10:57 PM
And manually label on the dashboard doc page
u

user

01/14/2021, 10:57 PM
That might be the easiest at first
u

user

01/14/2021, 10:58 PM
Least lockin too
u

user

01/14/2021, 11:00 PM
why not in the spec?
u

user

01/14/2021, 11:04 PM
^because we don’t control specs of connectors out in the wild
u

user

01/14/2021, 11:05 PM
yeah
u

user

01/14/2021, 11:05 PM
if someone uses a 3rd party docker image it should never say it’s airbyte certified within our UI
u

user

01/14/2021, 11:07 PM
huh. fair.
u

user

01/14/2021, 11:07 PM
so i guess we are saying we would want to be able to certify connectors we don't control?
u

user

01/14/2021, 11:07 PM
mm no
u

user

01/14/2021, 11:07 PM
I think we’re just saying that we want to control certification.
u

user

01/14/2021, 11:08 PM
I suppose we could certify external ones if we wanted but that definitely isn’t a priority
u

user

01/14/2021, 11:08 PM
it feels like we need a new “table” in our configs then
u

user

01/14/2021, 11:08 PM
linking version to certification status
u

user

01/14/2021, 11:11 PM
Yeah
u

user

01/14/2021, 11:11 PM
We can also use a json file in master for the UI too. It could pull that as an “api” to get the current list
u

user

01/14/2021, 11:11 PM
at least to tide us over
u

user

01/14/2021, 11:11 PM
I’d like to limit table creation as much as possible so we don’t have to do db migrations
u

user

01/14/2021, 11:12 PM
I imagine our tiers/certification will change over time
u

user

01/14/2021, 11:12 PM
I think for now I’ll just remove the certification from badging and purely handle it in documentation
u

user

01/14/2021, 11:12 PM
tu
u

user

01/14/2021, 11:12 PM
And we can add that on later when it gets solidified more
u

user

01/16/2021, 12:40 AM
to follow up
4 Views