https://linen.dev logo
a

Artem Astapenko

01/21/2021, 2:03 PM
Are we running CI on all PRs or only on PRs within team? I can’t see that it run for this https://github.com/airbytehq/airbyte/pull/1736
u

user

01/21/2021, 2:05 PM
Once it was merged on master, there was this build i think: https://github.com/airbytehq/airbyte/runs/1742097539?check_suite_focus=true
u

user

01/21/2021, 2:06 PM
well when its merged in master - there is commit from someone within the team. And its quite obvious that it will run in master, but shouldn’t it also run on every PR in some limited version?
u

user

01/21/2021, 4:34 PM
currently the build doesn't run for PRs from forks.
u

user

01/21/2021, 4:34 PM
it seems like if we can get it to run for forks though that we would prefer thyat.
u

user

01/21/2021, 4:35 PM
i'm not sure if there was a technical reason we did it this way or if we set it up when we were still having to pay for github actions and were being conservative.
u

user

01/21/2021, 4:35 PM
@Jared Rhizor (Airbyte) do you know off the top of your head?
u

user

01/21/2021, 4:45 PM
IIRC workflows can run in forked repos but the owner of the forked repo has to enable actions themselves. Then the actions run on their fork (they can’t access creds on the main repo)
u

user

01/21/2021, 4:46 PM
oh. interesting.
u

user

01/21/2021, 4:46 PM
and that's free for them, right?
u

user

01/21/2021, 4:46 PM
yeah should be
u

user

01/21/2021, 4:47 PM
should we add this as a suggestion in the PR template as an (optional) suggestion if they want to see the build info?
u

user

01/21/2021, 4:49 PM
I do not think that potential contributors want to enable git actions in their forked repo. Anyway it won’t give us much info as we will need to check their repo to make sure that PR is passing.
u

user

01/21/2021, 4:49 PM
true.
u

user

01/21/2021, 4:49 PM
The issue was that I totally missed that CI is not running in contributor’s PRs and merged it.
u

user

01/21/2021, 4:49 PM
no big deal. it happens.
u

user

01/21/2021, 4:49 PM
So ideally if somebody is contributing - we want to see whether we can merge or not.
u

user

01/21/2021, 4:50 PM
what if we add a trigger to allow someone to run the build via a comment?
u

user

01/21/2021, 4:50 PM
(like we do for running integration tests)
u

user

01/21/2021, 4:50 PM
I don’t think that works for forked prs
u

user

01/21/2021, 4:50 PM
for the same reason
u

user

01/21/2021, 4:50 PM
actually
u

user

01/21/2021, 4:51 PM
i don’t know how that works.
u

user

01/21/2021, 4:51 PM
maybe it is possible since the trigger is defined in the main repo?
u

user

01/21/2021, 4:51 PM
oh. i thought the zazmic guys were doing.
u

user

01/21/2021, 4:52 PM
zazmic guys are now PR-ing without forks
u

user

01/21/2021, 4:53 PM
this PR is from before they were using main repo.
u

user

01/21/2021, 4:55 PM
that actually shows the problem
u

user

01/21/2021, 4:56 PM
Error: No ref found for: source-mixpanel
u

user

01/21/2021, 4:56 PM
you can trigger master branch builds with ref=master like hte later ones do
u

user

01/21/2021, 4:56 PM
aaaah.
u

user

01/21/2021, 4:56 PM
makes sense.
u

user

01/21/2021, 4:56 PM
We can probably configure it to checkout a different project (the fork one) but that’s risky because anyone could run a PR and then print out all our secrets
u

user

01/21/2021, 4:57 PM
yeah. that seems like a no go.
u

user

01/21/2021, 4:57 PM
this seems like a weird problem.
u

user

01/21/2021, 4:57 PM
I would better vote to not assume that we will run something in forks. Also if we use some env variables that are set in github, which one will it take for fork’s CI?
u

user

01/21/2021, 4:57 PM
if we were using any other build system this would not be a problem, right? like i have contributed to OSS on a fork and the travis build or whatever has run
u

user

01/21/2021, 4:58 PM
yeah
u

user

01/21/2021, 4:58 PM
some non-github action things let you control secrets access on forks
u

user

01/21/2021, 4:58 PM
so i guess the question is: is this specific to gh actions and it is intractable or is it specific to how we are using gh actions.
u

user

01/21/2021, 4:58 PM
or let you run modified CI on forks that the forks cannot modify
u

user

01/21/2021, 4:58 PM
I think it’s specific to github actions, and impossible to do safely on github actions.
u

user

01/21/2021, 4:59 PM
well **
u

user

01/21/2021, 4:59 PM
maybe not impossible, but it feels like it’d be hard to guarantee safety
u

user

01/21/2021, 4:59 PM
it definitely is possible on some other platforms
u

user

01/21/2021, 5:00 PM
I think Sherif was looking into some at some point
5 Views