Channels
a
Artem Astapenko
01/21/2021, 2:03 PMAre we running CI on all PRs or only on PRs within team? I can’t see that it run for this https://github.com/airbytehq/airbyte/pull/1736
u
user
01/21/2021, 2:05 PMOnce it was merged on master, there was this build i think: https://github.com/airbytehq/airbyte/runs/1742097539?check_suite_focus=true
u
user
01/21/2021, 2:06 PMwell when its merged in master - there is commit from someone within the team. And its quite obvious that it will run in master, but shouldn’t it also run on every PR in some limited version?
u
user
01/21/2021, 4:34 PMcurrently the build doesn't run for PRs from forks.
u
user
01/21/2021, 4:34 PMit seems like if we can get it to run for forks though that we would prefer thyat.
u
user
01/21/2021, 4:35 PMi'm not sure if there was a technical reason we did it this way or if we set it up when we were still having to pay for github actions and were being conservative.
u
user
01/21/2021, 4:35 PM@Jared Rhizor (Airbyte) do you know off the top of your head?
u
user
01/21/2021, 4:45 PMIIRC workflows can run in forked repos but the owner of the forked repo has to enable actions themselves. Then the actions run on their fork (they can’t access creds on the main repo)
u
user
01/21/2021, 4:46 PMoh. interesting.
u
user
01/21/2021, 4:46 PMand that's free for them, right?
u
user
01/21/2021, 4:46 PMyeah should be
u
user
01/21/2021, 4:47 PMshould we add this as a suggestion in the PR template as an (optional) suggestion if they want to see the build info?
u
user
01/21/2021, 4:49 PMI do not think that potential contributors want to enable git actions in their forked repo. Anyway it won’t give us much info as we will need to check their repo to make sure that PR is passing.
u
user
01/21/2021, 4:49 PMtrue.
u
user
01/21/2021, 4:49 PMThe issue was that I totally missed that CI is not running in contributor’s PRs and merged it.
u
user
01/21/2021, 4:49 PMno big deal. it happens.
u
user
01/21/2021, 4:49 PMSo ideally if somebody is contributing - we want to see whether we can merge or not.
u
user
01/21/2021, 4:50 PMwhat if we add a trigger to allow someone to run the build via a comment?
u
user
01/21/2021, 4:50 PM(like we do for running integration tests)
u
user
01/21/2021, 4:50 PMI don’t think that works for forked prs
u
user
01/21/2021, 4:50 PMfor the same reason
u
user
01/21/2021, 4:50 PMactually
u
user
01/21/2021, 4:51 PMi don’t know how that works.
u
user
01/21/2021, 4:51 PMmaybe it is possible since the trigger is defined in the main repo?
u
user
01/21/2021, 4:51 PMoh. i thought the zazmic guys were doing.
u
user
01/21/2021, 4:52 PMzazmic guys are now PR-ing without forks
u
user
01/21/2021, 4:52 PMu
user
01/21/2021, 4:53 PMthis PR is from before they were using main repo.
u
user
01/21/2021, 4:55 PMthat actually shows the problem
u
user
01/21/2021, 4:56 PMError: No ref found for: source-mixpanel
u
user
01/21/2021, 4:56 PMyou can trigger master branch builds with ref=master like hte later ones do
u
user
01/21/2021, 4:56 PMaaaah.
u
user
01/21/2021, 4:56 PMmakes sense.
u
user
01/21/2021, 4:56 PMWe can probably configure it to checkout a different project (the fork one) but that’s risky because anyone could run a PR and then print out all our secrets
u
user
01/21/2021, 4:57 PMyeah. that seems like a no go.
u
user
01/21/2021, 4:57 PMthis seems like a weird problem.
u
user
01/21/2021, 4:57 PMI would better vote to not assume that we will run something in forks. Also if we use some env variables that are set in github, which one will it take for fork’s CI?
u
user
01/21/2021, 4:57 PMif we were using any other build system this would not be a problem, right? like i have contributed to OSS on a fork and the travis build or whatever has run
u
user
01/21/2021, 4:58 PMyeah
u
user
01/21/2021, 4:58 PMsome non-github action things let you control secrets access on forks
u
user
01/21/2021, 4:58 PMso i guess the question is: is this specific to gh actions and it is intractable or is it specific to how we are using gh actions.
u
user
01/21/2021, 4:58 PMor let you run modified CI on forks that the forks cannot modify
u
user
01/21/2021, 4:58 PMI think it’s specific to github actions, and impossible to do safely on github actions.
u
user
01/21/2021, 4:59 PMwell **
u
user
01/21/2021, 4:59 PMmaybe not impossible, but it feels like it’d be hard to guarantee safety
u
user
01/21/2021, 4:59 PMit definitely is possible on some other platforms
u
user
01/21/2021, 5:00 PMI think Sherif was looking into some at some point
5 Views