I've collected svg logos for every source that airbyte has, do you guys want me to submit a PR with those? If so, let me know where you want them.

OMG! I am wondering if this is something we should put in the spec for each connector

either as-is or as an encoded string

i think there should be some constraints to aspect ratio, background color (read: transparency) and margins

I've written a script to convert them to png so they all look similar

you had all of them as SVG before?

yup

thinking out loud right now

They're all transparent but they're all different sizes and may not render perfectly

what if we add a field at the top level of spec: svgIcon: "base64 encoded svg" or plain svg

part of the review for new connector is to ensure the icon looks good

base64encoded +1

(maybe with some guidelines: square aspect ratio & transparent background)

svg may not play nicely due to quotes

that would be awesome

I like keeping SVG since it is vectorial so it should zoom in/out very well

svg is definitely the way to go

only one source has a "non-compatible" square icon, stripe

why do you say it is non-compatible?

it's possible to design this logo in vector, but its not easy and expensive to render

png is a better fomart for this type of logo

the svg in the archive looks decent doesn't it?

yes, but its not the right one, lol 🙂

i do think svg is better than any image format to be embedded in the spec

yep. Also they use the svg for the mobile app so it seems to be an official logo

💥 https://github.com/airbytehq/airbyte/issues/2122

Oh interesting!

issue written == half the work done 😛

awesome

thank you so much for it!!

If you're interested, Clearbit has a free API for this https://clearbit.com/logo