What are people’s thoughts on Reviewable?

Davin and I were just discussing how much we liked it.

And it’s free for open source

But it’s kind of irritating if everyone isn’t using it for reviews.

So if you hate it speak now.

how will this work for contributors?

i was not a big fan of reviewable.

it’s free for contributors on open source as well

I think it’s a good question if we should use it for them

I think the main reason I liked reviewable was looking at like a 1k line PR

yeah more of a question of whether we want to foce people to use a non standard tool.

and then 300 lines change across 10 files

and then I can review only the changes

I would be fine using reviewable internally and github for external reviews too.

Most large PRs are internal

is this a problem we are having a lot?

this problem isn't really resonating with me.

but maybe my hearing aid is off.

I’ve regularly run into reviews where it’s hard to diff between review rounds

Basically every review that had request changes and had changes would have saved at a minimum 5 min with reviewable.

@Jared Rhizor (Airbyte), you can do “Show changes since your last review” in Github natively. Also you can pick specific commits to review. Have you tried that?

Ah nice. Didn’t know.

Outside of that issue resolution for fixes was the main benefit.

I do love reviewable’s file matrix and how each comment can be designed as informing, discussing, blocking etc

the file matrix makes it much easier to see at a glance what files have changed, so I can quickly zoom into a file I’m interested in

it also displays differences between two commits. can be useful if the a refactoring took several commits to finish and there was no squashing

agree reviewable is more useful for PRs with many LOC or files

throwing out there for discussion, what about reviewable for internal PRs and github for external PRs?

I think this internal/external dichotomy isn’t right — we are building in public which means everything should as much as possible go through the same process. Does reviewable mirror to/from GH comments/reviews? If so, i don’t really have a preference. I will probably try it out and if I don’t like it, I’ll fall back to GH. But if it doesn’t mirror, I think it’s not a good idea because it’s hiding context.

yeah it does mirror

it’s just irritating from the person creating the pr to manage responses from both inside and outside of reviewable. it’s fine for someone creating a pr to handle everything from github even if only some reviews are from reviewable