[itt] `airbyte-cli` build failure
# contributing-to-airbytej
Jared Rhizor (Airbyte)
04/26/2021, 10:08 PM
[itt]
airbyte-cliu
user
04/26/2021, 10:09 PMIt looks like both the current v0.7.0 and the commit we were using
4aa30c3f866cf4a551c64ea3d4c6eefea72cf2bc Copy code
#5 28.05 # <http://github.com/danielgtaylor/restish/openapi|github.com/danielgtaylor/restish/openapi>
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:367:16: invalid type assertion: v.Default.(string) (non-interface type string on left)
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:373:22: invalid type assertion: v.Enum[j].(string) (non-interface type string on left)
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:400:12: undefined: openapi3.NewSwaggerLoader
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:520:44: undefined: openapi3.Swagger
#5 ERROR: executor failed running [/bin/sh -c go get -u <http://github.com/danielgtaylor/restish@v0.7.0|github.com/danielgtaylor/restish@v0.7.0>]: exit code: 2u
user
04/26/2021, 10:09 PM@Davin Chia (Airbyte)
u
user
04/26/2021, 10:17 PMwhere are you seeing this?
u
user
04/26/2021, 10:27 PMyeah.
u
user
04/26/2021, 10:27 PMi was mucking with this. changing the version doesn't seem to fix it?
u
user
04/26/2021, 10:27 PMlike i'm trying with
RUN go get -u <http://github.com/danielgtaylor/restish@v0.7.0|github.com/danielgtaylor/restish@v0.7.0>u
user
04/26/2021, 10:29 PM@Davin Chia (Airbyte) in order to reproduce this you need to clean our your docker cache.
u
user
04/26/2021, 10:29 PMwait - we have Go?
u
user
04/26/2021, 10:29 PM./gradlew :airbyte-cli:airbyteDockeru
user
04/26/2021, 10:29 PMthen run that ^
u
user
04/26/2021, 10:29 PMsome library we use depends on a go thing.
u
user
04/26/2021, 10:29 PMI thought Jared was talking in the abstract about Go
u
user
04/26/2021, 10:41 PMdavin are you able to decipher why this code is not comiling?
u
user
04/26/2021, 10:42 PMOh I was mostly joking since you have such a high opinion of Go, but we do use it in this one place.
u
user
04/26/2021, 10:43 PMor jared. any thoughts on what's up?
u
user
04/26/2021, 10:43 PMreading this it looks like it's failing to import a class
u
user
04/26/2021, 10:43 PMfrom a dep
u
user
04/26/2021, 10:43 PMbut in that dep it looks like the class is there.
u
user
04/26/2021, 10:43 PMso i'm not sure what's going wrong.
u
user
04/26/2021, 10:47 PMI'm a couple of steps behind you. what version of Go are you using?
u
user
04/26/2021, 10:47 PMIt’s all in the Docker image
u
user
04/26/2021, 10:47 PM1.14
u
user
04/26/2021, 10:47 PMhttps://github.com/getkin/kin-openapi/blob/17153345908503543b50b7b6409f9d030bae0beb/openapi3/swagger_loader.go#L52 this is the thing it says it can’t find
u
user
04/26/2021, 10:47 PMbut it's there!
u
user
04/26/2021, 10:48 PMinfuriating.
u
user
04/26/2021, 10:48 PMinterestingly 4 hr ago their most recent release changed off of this
u
user
04/26/2021, 10:48 PMu
user
04/26/2021, 10:48 PMwhich seems very suspicious. I’m just not sure where it’s picking up the wrong version for it
u
user
04/26/2021, 10:48 PMoh
u
user
04/26/2021, 10:49 PMi'll try switching it to NewLoader and see if that helps
u
user
04/26/2021, 10:50 PMI'm confused because I can't reproduce this and all I see in the airbyte-cli directory is a docker file haha
u
u
user
04/26/2021, 10:50 PMthe thing is we were on this old branch
u
user
04/26/2021, 10:50 PMsorry am useless here
u
user
04/26/2021, 10:50 PM@Davin Chia (Airbyte) it literally is just that docker file
u
user
04/26/2021, 10:50 PMtrying.
u
user
04/26/2021, 10:50 PMthe docker build is failing since
go get -u <http://github.com/danielgtaylor/restish@4aa30c3f866cf4a551c64ea3d4c6eefea72cf2bc|github.com/danielgtaylor/restish@4aa30c3f866cf4a551c64ea3d4c6eefea72cf2bc>u
user
04/26/2021, 10:50 PMdid you clear out your docker cache davin?
u
user
04/26/2021, 10:51 PMah I see
u
user
04/26/2021, 10:51 PMokay this makes sense now
u
user
04/26/2021, 10:52 PMthere’s a line in the logs actually
u
user
04/26/2021, 10:52 PM#5 7.354 go: <http://github.com/getkin/kin-openapi|github.com/getkin/kin-openapi> upgrade => v0.61.0u
user
04/26/2021, 10:52 PMwhich looks like the problem
u
user
04/26/2021, 10:57 PMi'm trying to just fork it and fix it https://github.com/danielgtaylor/restish/compare/main...cgardens:cgardens/fix_kin_open_api?expand=1
u
user
04/26/2021, 10:57 PMbut doing this
RUN go get -u <http://github.com/cgardens/restish@8e61fbd56d4cf416d2db06131661b9956917f3b5|github.com/cgardens/restish@8e61fbd56d4cf416d2db06131661b9956917f3b5>u
user
04/26/2021, 10:57 PMi'm like a monkey at a typewriter.
u
user
04/26/2021, 10:58 PMeven version 0.7.0 has an older version of the openapi lib https://github.com/danielgtaylor/restish/blob/v0.7.0/go.mod#L21
u
user
04/26/2021, 10:59 PMI’m not familiar with go modules at all, so maybe I’m reading this all wrong. I just assume that a version in the go.mod file would represent the version it pulls from?
u
user
04/26/2021, 11:00 PMwhy is it downloading kin-openapi v0.61.0 in the first place?
u
user
04/26/2021, 11:04 PMliterally no idea.
u
user
04/26/2021, 11:04 PM@Davin Chia (Airbyte) any chance we could jump on a quick call to figure this out
u
user
04/26/2021, 11:05 PM@charles if this is blocking you from merging code I would just remove it from the build temporarily
u
user
04/26/2021, 11:05 PMthe published version isn’t broken, only the current build
u
user
04/26/2021, 11:05 PMlet's do it
u
user
04/26/2021, 11:05 PMcan i join?
u
user
04/26/2021, 11:05 PMi'm curious at this point.
u
user
04/26/2021, 11:05 PMI was refreshing my knowledge of Go Mods
u
user
04/26/2021, 11:12 PMu
user
04/26/2021, 11:27 PMcreated an issue on their github https://github.com/danielgtaylor/restish/issues/41
u
user
04/26/2021, 11:27 PMthey were super responsive for a feature request in the past
u
user
04/26/2021, 11:55 PMdo it again!
u
user
04/26/2021, 11:55 PMwe are close
u
user
04/26/2021, 11:55 PMoops we got kicked out
u
user
04/26/2021, 11:55 PMu
user
04/27/2021, 12:06 AMnailed it. my first golang pr https://github.com/danielgtaylor/restish/pull/42
u
user
04/27/2021, 12:09 AMthanks for doing all the real work here davin.
2 Views