https://linen.dev logo
Channels
Powered by
j

Jared Rhizor (Airbyte)

04/26/2021, 10:08 PM
[itt] 
airbyte-cli
build failure
u

user

04/26/2021, 10:09 PM
It looks like both the current v0.7.0 and the commit we were using 
4aa30c3f866cf4a551c64ea3d4c6eefea72cf2bc
are failing to pull in some dependencies?
Copy code
#5 28.05 # <http://github.com/danielgtaylor/restish/openapi|github.com/danielgtaylor/restish/openapi>
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:367:16: invalid type assertion: v.Default.(string) (non-interface type string on left)
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:373:22: invalid type assertion: v.Enum[j].(string) (non-interface type string on left)
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:400:12: undefined: openapi3.NewSwaggerLoader
#5 28.05 pkg/mod/github.com/danielgtaylor/restish@v0.7.0/openapi/openapi.go:520:44: undefined: openapi3.Swagger
#5 ERROR: executor failed running [/bin/sh -c go get -u <http://github.com/danielgtaylor/restish@v0.7.0|github.com/danielgtaylor/restish@v0.7.0>]: exit code: 2
u

user

04/26/2021, 10:09 PM
@Davin Chia (Airbyte)
u

user

04/26/2021, 10:17 PM
where are you seeing this?
u

user

04/26/2021, 10:27 PM
yeah.
u

user

04/26/2021, 10:27 PM
i was mucking with this. changing the version doesn't seem to fix it?
u

user

04/26/2021, 10:27 PM
like i'm trying with 
RUN go get -u <http://github.com/danielgtaylor/restish@v0.7.0|github.com/danielgtaylor/restish@v0.7.0>
and getting the same error.
u

user

04/26/2021, 10:29 PM
@Davin Chia (Airbyte) in order to reproduce this you need to clean our your docker cache.
u

user

04/26/2021, 10:29 PM
wait - we have Go?
u

user

04/26/2021, 10:29 PM
./gradlew :airbyte-cli:airbyteDocker
u

user

04/26/2021, 10:29 PM
then run that ^
u

user

04/26/2021, 10:29 PM
some library we use depends on a go thing.
u

user

04/26/2021, 10:29 PM
I thought Jared was talking in the abstract about Go
u

user

04/26/2021, 10:41 PM
davin are you able to decipher why this code is not comiling?
u

user

04/26/2021, 10:42 PM
Oh I was mostly joking since you have such a high opinion of Go, but we do use it in this one place.
u

user

04/26/2021, 10:43 PM
or jared. any thoughts on what's up?
u

user

04/26/2021, 10:43 PM
reading this it looks like it's failing to import a class
u

user

04/26/2021, 10:43 PM
from a dep
u

user

04/26/2021, 10:43 PM
but in that dep it looks like the class is there.
u

user

04/26/2021, 10:43 PM
so i'm not sure what's going wrong.
u

user

04/26/2021, 10:47 PM
I'm a couple of steps behind you. what version of Go are you using?
u

user

04/26/2021, 10:47 PM
It’s all in the Docker image
u

user

04/26/2021, 10:47 PM
1.14
u

user

04/26/2021, 10:47 PM
u

user

04/26/2021, 10:47 PM
but it's there!
u

user

04/26/2021, 10:48 PM
infuriating.
u

user

04/26/2021, 10:48 PM
interestingly 4 hr ago their most recent release changed off of this
u

user

04/26/2021, 10:48 PM
u

user

04/26/2021, 10:48 PM
which seems very suspicious. I’m just not sure where it’s picking up the wrong version for it
u

user

04/26/2021, 10:48 PM
oh
u

user

04/26/2021, 10:49 PM
i'll try switching it to NewLoader and see if that helps
u

user

04/26/2021, 10:50 PM
I'm confused because I can't reproduce this and all I see in the airbyte-cli directory is a docker file haha
u

user

04/26/2021, 10:50 PM
u

user

04/26/2021, 10:50 PM
the thing is we were on this old branch
u

user

04/26/2021, 10:50 PM
sorry am useless here
u

user

04/26/2021, 10:50 PM
@Davin Chia (Airbyte) it literally is just that docker file
u

user

04/26/2021, 10:50 PM
trying.
u

user

04/26/2021, 10:50 PM
the docker build is failing since 
go get -u <http://github.com/danielgtaylor/restish@4aa30c3f866cf4a551c64ea3d4c6eefea72cf2bc|github.com/danielgtaylor/restish@4aa30c3f866cf4a551c64ea3d4c6eefea72cf2bc>
just started failing earlier today
u

user

04/26/2021, 10:50 PM
did you clear out your docker cache davin?
u

user

04/26/2021, 10:51 PM
ah I see
u

user

04/26/2021, 10:51 PM
okay this makes sense now
u

user

04/26/2021, 10:52 PM
there’s a line in the logs actually
u

user

04/26/2021, 10:52 PM
#5 7.354 go: <http://github.com/getkin/kin-openapi|github.com/getkin/kin-openapi> upgrade => v0.61.0
u

user

04/26/2021, 10:52 PM
which looks like the problem
u

user

04/26/2021, 10:57 PM
u

user

04/26/2021, 10:57 PM
but doing this 
RUN go get -u <http://github.com/cgardens/restish@8e61fbd56d4cf416d2db06131661b9956917f3b5|github.com/cgardens/restish@8e61fbd56d4cf416d2db06131661b9956917f3b5>
seems to still just try to pull @0.7.0 from main restish. 😞
u

user

04/26/2021, 10:57 PM
i'm like a monkey at a typewriter.
u

user

04/26/2021, 10:58 PM
even version 0.7.0 has an older version of the openapi lib https://github.com/danielgtaylor/restish/blob/v0.7.0/go.mod#L21
u

user

04/26/2021, 10:59 PM
I’m not familiar with go modules at all, so maybe I’m reading this all wrong. I just assume that a version in the go.mod file would represent the version it pulls from?
u

user

04/26/2021, 11:00 PM
why is it downloading kin-openapi v0.61.0 in the first place?
u

user

04/26/2021, 11:04 PM
literally no idea.
u

user

04/26/2021, 11:04 PM
@Davin Chia (Airbyte) any chance we could jump on a quick call to figure this out
u

user

04/26/2021, 11:05 PM
@charles if this is blocking you from merging code I would just remove it from the build temporarily
u

user

04/26/2021, 11:05 PM
the published version isn’t broken, only the current build
u

user

04/26/2021, 11:05 PM
let's do it
u

user

04/26/2021, 11:05 PM
can i join?
u

user

04/26/2021, 11:05 PM
i'm curious at this point.
u

user

04/26/2021, 11:05 PM
I was refreshing my knowledge of Go Mods
u

user

04/26/2021, 11:12 PM
u

user

04/26/2021, 11:27 PM
u

user

04/26/2021, 11:27 PM
they were super responsive for a feature request in the past
u

user

04/26/2021, 11:55 PM
do it again!
u

user

04/26/2021, 11:55 PM
we are close
u

user

04/26/2021, 11:55 PM
oops we got kicked out
u

user

04/26/2021, 11:55 PM
u

user

04/27/2021, 12:06 AM
u

user

04/27/2021, 12:09 AM
thanks for doing all the real work here davin.
2 Views
Powered by