Today, one of the most annoying parts of my workflow is remembering to run

./gradlew format

before pushing a change. Do other people feel the same way? How would people feel if Github did this for us?

e.g. For PR, Github automatically formats and commits any differences it finds

I always forget to run, whats about using

pre-commit

?

maybe. format takes a while to run (40 sec - 1 min) so it might be heavy if it's a pre-commit hook before every commit

that's why I'm leaning more towards a github action thing

however want to get people's opinion in case others don't think this is worth spending time on

It’s way too long as a hook

yeah. my current germinating idea is currently some sort of action that commits formatting changes to the branch on a push (if there are any). the only change to the local dev workflow is having to pull/merge before the next commit to grab formatting changes. still noodling

I suppose the 40 sec - 1 min format run is for the entire codebase, right? Can the pre-commit hook just run for the changed files to be committed?

Incremental formatting would help a lot.

Liren - possible. Haven’t looked in depth

Jared you meant incremental via gradle?

yeah

like if this command took like 1 second

it’d be fine as a hook

the formatting we use should be able to only look at the files which changed compare to a base

there is an option in the plugin

Looks like there is no exact option to format code just for changed files. But

ratchetFrom

is pretty close. Here is an issue with some candidate solutions: https://github.com/diffplug/spotless/issues/178

I can take care of this after May 7th, if it is not resolved sooner.