Hi, guys! I had a conversation with <@U01BV1SDQMA>...
# contributing-to-airbyte
o
Hi, guys! I had a conversation with @Chris (deprecated profile) regarding the step 3 from https://docs.airbyte.io/connector-development#publishing-a-connector . Does this step is still valid? The reason why I am asking the last version of bigquery-denormalized destination connector has valid version in
resources/seed/destination_definitions.yaml
and
airbyte-integrations/connectors/destination-bigquery-denormalized/Dockerfile
but not in
resources/config/STANDARD_DESTINATION_DEFINITION/079d5540-f236-4294-ba7c-ade8fd918496.json
. Thanks.
u
The reason why they have different versions is because of me and my last PR where I updated the yaml file but not the json file. I did not do it intentionally but because that’s the workflow I was used to (ie. update the yaml file, run gradle build and commit whatever to the PR and magically the json file would be up to date too)
o
But since this PR https://github.com/airbytehq/airbyte/pull/5335 there was this comment: https://github.com/airbytehq/airbyte/pull/5335/files#r689937766 Do we still need to keep updating (manually) the version in the json files? • if yes, can we restore the
generateSeed
gradle task? • if no, can we update the docs? @charles @Liren Tu
u
Anyway, If we suppose to do this step manually, Am I free to skip
"0.1.7"
and bump it to my next version
"0.1.8"
in JSON file? Thanks.
u
yes go ahead
u
nope. step 3 can be removed.