https://linen.dev logo
o

Oleksandr Tsukanov [GL]

11/03/2021, 11:16 AM
Hello, everybody! Is it correct statement after https://github.com/airbytehq/airbyte/pull/7501/files was merged we should bump connector version
airbyte-config/init/src/main/resources/seed/destination_specs.yaml
or here
airbyte-config/init/src/main/resources/seed/source_specs.yaml
as well? Thanks.
u

user

11/03/2021, 11:17 AM
I mean, the case, when we update connector
u

user

11/03/2021, 11:19 AM
u

user

11/03/2021, 11:21 AM
maybe worth adjusting further the docs here: https://github.com/airbytehq/airbyte/pull/7589
o

Oleksandr Tsukanov [GL]

11/03/2021, 11:26 AM
So, this will come as additional step?
u

user

11/03/2021, 11:28 AM
I don’t know, @Lake Mossman will be able to better answer…
o

Oleksandr Tsukanov [GL]

11/03/2021, 11:28 AM
ok, thanks
u

user

11/03/2021, 1:51 PM
@Davin Chia (Airbyte)
o

Oleksandr Bazarnov [GL]

11/03/2021, 1:54 PM
Are you familiar with this mechanism of autogenerating the
seed/*_specs.yaml
? Should the updated version of the connector be
/published
beforehand? What about the new connectors?
o

Oleksandr Bazarnov [GL]

11/03/2021, 1:55 PM
You have to publish the new image, then rerun the build after that so the spec is added to the platform connector cache. So there is an extra step for ya guys
u

user

11/03/2021, 1:55 PM
I asked Sherif where to update publishing docs and didn’t get a reply. Looks like Chris already has a PR open!
u

user

11/03/2021, 1:56 PM
Lake (who is already tagged here), can you add to that PR when you get up?
u

user

11/03/2021, 1:58 PM
I see, my understanding of this was correct I guess)
u

user

11/03/2021, 1:58 PM
ok, I’ll update my teammates about this
u

user

11/03/2021, 2:09 PM
I never doubted you sasha 🙂
o

Oleksandr Bazarnov [GL]

11/03/2021, 2:09 PM
great, thank you
Hello @Davin Chia (Airbyte) I develop the new connector https://github.com/airbytehq/airbyte/pull/7407 it looks like I need to “/publish” it for tests passed - OK can I publish it ?
u

user

11/03/2021, 2:29 PM
I see that from now we need to publish connectors which still on review stage to make tests passed ok
u

user

11/03/2021, 2:29 PM
if the connector tests are passing and the PR has been approved than yes, please publish it
u

user

11/03/2021, 2:30 PM
in this case, I don’t think the connector has been approved yet, so we should not publish it
u

user

11/03/2021, 2:31 PM
it is okay if the build isn’t passing for now since you can still test your change via the /test command
u

user

11/03/2021, 2:33 PM
Lake, affecting the connector teams is what I was slightly worried about. I think we should only run the spec check in the platform build. The connector build is untouched for a connector dev to develop on. They have to make sure the platform build passes still, so it should overall be ok
o

Oleksandr Bazarnov [GL]

11/03/2021, 2:35 PM
By the way what if /test command fails due to e.g.
Exception in thread "main" java.lang.RuntimeException: Failed to fetch valid spec file for docker image airbyte/source-mysql:0.4.9 from GCS bucket io-airbyte-cloud-spec-cache
? To fix that I need to publish the connector. However, I don’t have guarantees, integration tests passed and build is successful, etc.
for me it looks like chicken or egg problem my new connector cannot pass tests for now because of this error
Copy code
Error: Exception in thread "main" java.lang.RuntimeException: Failed to fetch valid spec file for docker image airbyte/source-youtube-analytics:0.1.0 from GCS bucket io-airbyte-cloud-spec-cache
and as I understand to overcome this error I need to publish my connector image
u

user

11/03/2021, 2:38 PM
oh is it failing?
u

user

11/03/2021, 2:38 PM
yep)
u

user

11/03/2021, 2:38 PM
okay give me a few mins
u

user

11/03/2021, 2:44 PM
does also this block /test commands?
o

Oleksandr Bazarnov [GL]

11/03/2021, 2:45 PM
u

user

11/03/2021, 2:49 PM
hm yes, it seems “/test” not blocked
u

user

11/03/2021, 2:56 PM
great, is it okay if we work off /test for the time being? we can figure this out when Lake gets up tomorrow
o

Oleksandr Bazarnov [GL]

11/03/2021, 3:08 PM
I just try to clarify for myself how to move forward my PR because some Airbyte CI stages are become RED for now
u

user

11/03/2021, 3:08 PM
Thank you!
u

user

11/03/2021, 3:45 PM
Hello all, sorry for all of the friction this has caused! I am going to revert my change while we figure out the best way to move forward with this