Hello, everybody! Is it correct statement after https://github.com/airbytehq/airbyte/pull/7501/files was merged we should bump connector version

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

or here

airbyte-config/init/src/main/resources/seed/source_specs.yaml

as well? Thanks.

I mean, the case, when we update connector

I think you have some new indications here: https://github.com/airbytehq/airbyte/tree/master/airbyte-config/specs

maybe worth adjusting further the docs here: https://github.com/airbytehq/airbyte/pull/7589

So, this will come as additional step?

I don’t know, @Lake Mossman will be able to better answer…

ok, thanks

Are you familiar with this mechanism of autogenerating the

seed/*_specs.yaml

? Should the updated version of the connector be

/published

beforehand? What about the new connectors?

See https://github.com/airbytehq/airbyte/pull/7501#pullrequestreview-794923555

You have to publish the new image, then rerun the build after that so the spec is added to the platform connector cache. So there is an extra step for ya guys

I asked Sherif where to update publishing docs and didn’t get a reply. Looks like Chris already has a PR open!

Lake (who is already tagged here), can you add to that PR when you get up?

I see, my understanding of this was correct I guess)

ok, I’ll update my teammates about this

I never doubted you sasha 🙂

great, thank you

I see that from now we need to publish connectors which still on review stage to make tests passed ok

if the connector tests are passing and the PR has been approved than yes, please publish it

in this case, I don’t think the connector has been approved yet, so we should not publish it

it is okay if the build isn’t passing for now since you can still test your change via the /test command

Lake, affecting the connector teams is what I was slightly worried about. I think we should only run the spec check in the platform build. The connector build is untouched for a connector dev to develop on. They have to make sure the platform build passes still, so it should overall be ok

By the way what if /test command fails due to e.g.

Exception in thread "main" java.lang.RuntimeException: Failed to fetch valid spec file for docker image airbyte/source-mysql:0.4.9 from GCS bucket io-airbyte-cloud-spec-cache

? To fix that I need to publish the connector. However, I don’t have guarantees, integration tests passed and build is successful, etc.

oh is it failing?

yep)

okay give me a few mins

for example my case https://github.com/airbytehq/airbyte/runs/4091663450?check_suite_focus=true#step:12:181

does also this block /test commands?

https://github.com/airbytehq/airbyte/pull/7407#issuecomment-959261727 looks like it’s running ok?

hm yes, it seems “/test” not blocked

great, is it okay if we work off /test for the time being? we can figure this out when Lake gets up tomorrow

I just try to clarify for myself how to move forward my PR because some Airbyte CI stages are become RED for now

Thank you!

Hello all, sorry for all of the friction this has caused! I am going to revert my change while we figure out the best way to move forward with this