I think HttpStream could very easily be adapted to handle different type of data, but it depends up to which level it has to be resilient. I'm new to Airbyte so I don't know exactly what you promise there. 😅

I actually adapted HttpStream first but somehow couldn't find a way to have my own connector uses my changed version so I decided to take that shortcut for now.

But yeah basically, as far as I understand, the only missing link for now is that if you have SOAP, you need to send a XML body, so you shouldn't use the

json

parameter of request, but the

data

parameter. So what I would do is offering another method next to

request_body_json

, like

request_body_data

. People are free to implement whichever they need, and you can call both of them next to each other in

read_records

.

In my case, the json one will return None because I don't have anything to implement there, and that just work perfectly fine.

I just don't know what happens when both

data

and

json

are provided to requests, but that should be easy to find out. ^^

I'll add more details to the ticket as soon as I have a bit of time. 🙂