<@U01ADSJ1D5H> - I’m seeing build failures because...
# dev-frontendc
charles
09/22/2020, 5:02 PM
@Artem Astapenko - I’m seeing build failures because the build can’t find react-dom. I put up a PR that I think “fixes” it, but I sorta doubt this is actually the preferred way of fixing it. Would you mind taking a look? Here’s my PR.
m
Michel
09/22/2020, 5:14 PM
why did it start failing? (i have the same problem on one of my branch)
c
charles
09/22/2020, 5:14 PM
i don’t know.
charles
09/22/2020, 5:15 PM
my guess is its an npm thing. it’s failing everywhere. (including master)
a
Artem Astapenko
09/22/2020, 5:18 PMI am not quite sure what is the problem but I suppose it was working fine before. Am I wrong?
c
charles
09/22/2020, 5:19 PM
Correct. It was working before. As of this morning it started failing. I don’t think anyone has touched any of the npm or webapp stuff in our codebase, which is why my guess was that it was an issue with npm or the dependency itself.
a
Artem Astapenko
09/22/2020, 5:19 PMI know what’s the problem but I can’t understand why it started to fail.
Artem Astapenko
09/22/2020, 5:20 PMso if I install deps with yarn - everything is working fine, but npm install doesn’t load react-dom.
Artem Astapenko
09/22/2020, 5:21 PMI guess problem is again somewhere on npm side …
Or maybe we will need to switch to yarn to fix the build fast. But if nothing was changed - it is strange that its failing
3 Views