Charles, small question: for source_implementation...
# dev-frontenda
Artem Astapenko
09/22/2020, 9:38 PMCharles, small question: for source_implementation update and destination_implementation update, we can handle check_connection on frontend. The issue is that any implementation that we can do now will be confusing for user - because he will update, we will check values, return him error in case of error but actually new values will be stored instead of old one.
c
charles
09/22/2020, 9:44 PM
can you give an example? i’m not quite sure what you mean about new values and old values. like i think i roughly understand the type of issue, just not sure specifically what you are imagining.
charles
09/22/2020, 9:46 PM
is that i put in:
username: invalidusernameinvalida
Artem Astapenko
09/22/2020, 9:51 PMWhen you enter values for source_implementation: we can call on web_backend create and check_connection.
Artem Astapenko
09/22/2020, 9:52 PMSo lets assume everything was fine and it is created and user ended those flow.
Artem Astapenko
09/22/2020, 9:52 PMNow he wants to modify it.
Artem Astapenko
09/22/2020, 9:53 PMHe changes valid one source to invalid. We call update and then call check_connection. Now it fails, but our old working values will be changed to non-working now.
Artem Astapenko
09/22/2020, 9:53 PMAnd that could be quite confusing for user - he tried to change something and got an error. He may think that nothing was changed, but actually it was.
Artem Astapenko
09/22/2020, 9:54 PMtbh I suppose there is an error here. We should first check connection and then create an entity. Not vice versa. So you first validate and then create. Easier to support, easier to catch failed steps.
c
charles
09/22/2020, 9:55 PM
ah. i see what you’re saying.
charles
09/22/2020, 9:56 PM
i agree. i think for now we have to do it this confusing way though, because it’d be a kinda a major change otherwise. what do you think?
a
Artem Astapenko
09/22/2020, 9:57 PMsure. I am not asking to change anything now - its quite a big thing to do. I am just asking how should I handle it on FE 🙂
👍 1
Artem Astapenko
09/22/2020, 9:57 PMSo I can call check_connection after update - but that could be confusing for user.
c
charles
09/22/2020, 9:58 PM
yeah. makes sense.
charles
09/22/2020, 9:59 PM
let’s do that for now. thanks for pointing it out!
👍 1
3 Views