< Artem Astapenko> I m noticing an issue with the UI on mast Airbyte #dev-frontend

<@U01ADSJ1D5H> I’m noticing an issue with the UI o...

10/14/2020, 11:47 PM

@Artem Astapenko I’m noticing an issue with the UI on master — I ran a fresh version of the app (

docker-compose down && docker-compose down --volumes && docker-compose --env-file .env.dev -f docker-compose.yaml -f docker-compose.dev.yaml up

) but the UI breaks on the onboarding page with the exception in the screenshot. as far as i can tell all the network calls are returning appropriately. Do you know what the issue is here?

Artem Astapenko

10/14/2020, 11:47 PM

1 second

Artem Astapenko

10/14/2020, 11:47 PM

looking

Artem Astapenko

10/14/2020, 11:48 PM

hm, a bit strange as I just ran fresh version of my changes that were just based on master.

Artem Astapenko

10/14/2020, 11:49 PM

This error means that some entity did not return id ( or what is used as primary key )

10/14/2020, 11:49 PM

it could be that the UI is expecting a spec ID somewhere? (which were removed while this PR was approved but not merged)

Artem Astapenko

10/14/2020, 11:50 PM

yep. Thats what I was writing right now.

Artem Astapenko

10/14/2020, 11:51 PM

DestinationImplementationResource

and

SourceImplementationResource

expect their ids. So if they were removed and those changes are already merged - its possible that something may not work

Artem Astapenko

10/14/2020, 11:52 PM

but what is strange - that I do not have such problems with fresh master merged into my branch. Sorry its a bit late here, so I can’t take a look on it right now … but if error is still there by the morning - I will fix.

👍🏼 1

10/15/2020, 12:16 AM

https://github.com/airbytehq/airbyte/pull/572 i think this PR should fix the issue

Open in Slack

Previous Next