https://linen.dev logo
#dev-frontend
Title
# dev-frontend
c

charles

10/29/2020, 2:52 PM
hi @Artem Astapenko - we are writing integrations that rely on being able to render
oneOf
json schema (issue). do you think you would be able to get to this one before the weekend?
a

Artem Astapenko

10/29/2020, 2:53 PM
Let me check.
c

charles

10/29/2020, 2:57 PM
ideally. all of v0.4.0 could happen, but the one i mentioned above is the highest priority one. if the other ones slip a couple days it’s not a big deal.
it blocks us releasing two of our new integrations and the release we’re doing for v0.4.0 is all about the fact that we’ve added a lot of new integrations.
a

Artem Astapenko

10/29/2020, 3:03 PM
So before weekends means that I only have 1 day left 🙂 Not quite sure how easy it would be to support oneOf on all layers. So far I suppose it is doable within 1 day, but I am afraid I can face some problems.
c

charles

10/29/2020, 3:04 PM
okay. there’s not a library we can use, right? obviously react-json-schema support this. i know it’s not compatible with yup (?).
a

Artem Astapenko

10/29/2020, 3:04 PM
its not compatible with formik
👍 1
c

charles

10/29/2020, 3:06 PM
got it.
well if you can do tomorrow, that’d be great, i understand it’s a stretch.
a

Artem Astapenko

10/29/2020, 3:08 PM
we are using another library for forms 🙂 Actually logic is quite straightforward and shouldn’t cause any issues during implementation: just recursively render fields based on inner oneOf objects. Quite the same for validation. I am more concerned how formik handles form validation. It has some minor issues when you change schema on the fly.
👍 1
Sure I will do my best. Going to start implementing it right now.
c

charles

10/29/2020, 3:09 PM
are you planning to work over the weekend? i know sometimes you do, but i don’t want to assume you are. if you are planning to, if it’s done by monday morning that’s equally fine from our point of view.
a

Artem Astapenko

10/29/2020, 3:11 PM
I usually spend some time during the weekends. Anyway, if I do not have solution ready by the weekends, I will dedicate some time to finish it by Monday.
c

charles

10/29/2020, 3:11 PM
okay. thank you!!
👍 1
i appreciate it.
@Artem Astapenko did you have any luck on getting this one done? i know we sync in a few hours, but i’m writing up the plan for next week now so it would be helpful to know.
a

Artem Astapenko

11/02/2020, 3:36 PM
not yet. I have to make significant updates to code to make it work properly - the good thing that in future it will be much easier to support any sort of json-schema. I am doing my best to have it done asap
c

charles

11/02/2020, 3:36 PM
okay thanks!