https://linen.dev logo
#dev-frontend
Title
# dev-frontend
c

charles

11/18/2020, 11:37 PM
Hiya, @Artem Astapenko, is the multiple destinations stuff ready for us to review and try out or are you still working on it?
🙌 1
a

Artem Astapenko

11/19/2020, 10:11 AM
Hi, everything is ready - I am spending some time on testing. We need to spend some time on testing and after that can merge
c

charles

11/19/2020, 5:21 PM
Okay!
Thanks.
a

Artem Astapenko

11/19/2020, 5:21 PM
btw, guys, you can test. Let me update review 🙂
You can leave comments directly in review if you find any errors and tomorrow I am going to check everything 1 more time and merge 🙂
c

charles

11/19/2020, 5:24 PM
okay. we should just test by pulling down this branch right: source-and-destination-pages-0.5.0?
a

Artem Astapenko

11/19/2020, 6:00 PM
Yep
c

charles

11/22/2020, 11:46 PM
I tested this a little bit. Looking good! I'm having trouble getting syncs to succeed, which I think is just because master needs to be pulled in (i don't think it's a frontend issue).
a

Artem Astapenko

11/23/2020, 10:51 AM
Ok. I will merge last mater and test one more time. Hope today we can merge this feature :)
c

charles

11/23/2020, 3:14 PM
Great! Agreed.
Let me know when you have merge master and I will test one more time quickly.
a

Artem Astapenko

11/23/2020, 5:45 PM
Done
c

charles

11/23/2020, 6:40 PM
tested it and it is looking good to me!
i think you should merge it when you are happy with it.
i noticed one bug, but let's fix it after you merge.
message has been deleted
the destination name wasn't showing after i added an existing source to an existing destination.
refreshing the page fixed it.
after the page was refresh it was good:
message has been deleted
a

Artem Astapenko

11/23/2020, 7:13 PM
Merged! 🎉 Btw, will you create task for the issue above?
c

charles

11/23/2020, 7:13 PM
yes!
i will.
2 Views