https://www.activepieces.com logo
feat(amazon-s3): add Generate Signed Upl...
# 🐶|general
h
Whats a guy gotta do to get a PR merge around here haha? https://github.com/activepieces/activepieces/pull/12322
a
@Kishan Parmar can you please let one of the pieces team review this, apologies @hugh-codes for the delay, I would recommend you post this in the building pieces channel after you open it just so we can get better notificaiton about it.
h
No problem! thanks for the tip
anything else I should do for next time? what makes for an easy PR to review? Docs were very vague @Abdul (Viva-Palestina)💔
a
interesting you say this, could you please elaborate on what you found vague in the docs? i.e pr process, developing a piece...etc
h
https://www.activepieces.com/docs/build-pieces/sharing-pieces/contribute With regards to opening a pull request / contributing, the docs are very high level > Open a pull request > > Build and test your piece. > Open a pull request from your repository to the main fork. > A maintainer will review your work closely. abd there isn’t much detail on expectations or standards. It would be helpful to include more specific guidance so we know exactly what’s required before submitting, which could also make the review process smoother and less time consuming for you guys
a
we mainly make sure that the action works as intended and is readable in regards of code standards, we have linting rules that help with that
h
sweet! well I guess the docs are accurate then 🙂
k
@hugh-codes PR is merged.
h
Lets go! thank you @Kishan Parmar
2 Views