https://github.com/lldap/lldap logo
Join Discord
Powered by
# general
  • k

    Kumpelinus

    08/26/2025, 11:53 AM
    Only if you request a generation and supply your email though
  • n

    nitnelave

    08/26/2025, 11:53 AM
    There are some slight inaccuracies, or I wouldn't have presented things exactly the same way, but it's 95+% accurate
  • j

    jensen

    08/26/2025, 11:53 AM
    they werent somewhere in the readme already?
  • n

    nitnelave

    08/26/2025, 11:54 AM
    No, I didn't add my email (maybe someone else already did, though)
  • k

    Kumpelinus

    08/26/2025, 11:54 AM
    Yeah, I requested it for a few pages in the past. Only 1 person has to do it
  • n

    nitnelave

    08/26/2025, 11:54 AM
    The flow charts are definitely auto generated, that's one of the parts where I have the most issues
  • k

    Kumpelinus

    08/26/2025, 11:54 AM
    Idk whether I did it for lldap though
  • j

    jensen

    08/26/2025, 11:55 AM
    yeah, thats not one of my core competencies either ...
  • n

    nitnelave

    08/26/2025, 11:55 AM
    But not because they're inaccurate, only because the components are at different levels of abstractions, it doesn't follow any nice specific logical flow (but instead a mix of several)
  • n

    nitnelave

    08/26/2025, 11:56 AM
    It's not exactly a data flow, it's not exactly a code flow, or a dependency chart, but it has a bit of all
  • j

    jensen

    08/26/2025, 11:56 AM
    ah, misunderstood, hadnt checked them that closely yet 🙂
  • n

    nitnelave

    08/26/2025, 11:57 AM
    For instance, it has requests coming from either the GraphQL API or the ldap3_proto (the crate we use to parse LDAP)
  • k

    Kumpelinus

    08/26/2025, 8:12 PM
    @nitnelave I was just working on that issue 💀
  • k

    Kumpelinus

    08/26/2025, 8:12 PM
    Was planning to finish it today
  • k

    Kumpelinus

    08/26/2025, 8:12 PM
    I have everything besides the tests ready
  • n

    nitnelave

    08/26/2025, 8:17 PM
    Oh, the modified timestamp?
  • k

    Kumpelinus

    08/26/2025, 8:17 PM
    Yeah, exactly
  • n

    nitnelave

    08/26/2025, 8:17 PM
    Great, I trust your implementation more than copilot's 😄
  • k

    Kumpelinus

    08/26/2025, 8:17 PM
    I finally found time today
  • k

    Kumpelinus

    08/26/2025, 8:17 PM
    LOL
  • n

    nitnelave

    08/26/2025, 8:17 PM
    Next time, maybe drop a comment on the issue
  • k

    Kumpelinus

    08/26/2025, 8:17 PM
    I'll open a PR later
  • n

    nitnelave

    08/26/2025, 8:18 PM
    And don't worry, it cost me about 30s so far
  • k

    Kumpelinus

    08/26/2025, 8:18 PM
    Yeah, I only mentioned it in the discord and though no one would start working on that 2 year old issue on the day I was working on it XD. Will do next time though
  • n

    nitnelave

    08/26/2025, 10:36 PM
    Alright, I've just skimmed the PR from copilot, you have a surprisingly strong contender! https://github.com/lldap/lldap/pull/1264
  • k

    Kumpelinus

    08/26/2025, 10:45 PM
    Commited my current work for now. I am quite tired, so the finish might not be perfect.
  • k

    Kumpelinus

    08/26/2025, 10:51 PM
    @nitnelave in case you want me to continue, I would continue fixing my tests tmr. I don't mind you accepting the Copilot one either since I want to work on a few other issues as well in the near future.
  • n

    nitnelave

    08/26/2025, 11:02 PM
    It might be more productive for you to review the copilot PR since you have all the context, and give me your frank opinion. After that we can decide how to proceed
  • k

    Kumpelinus

    08/26/2025, 11:03 PM
    Alright. I will do that after a wake up from sleeping. That sounds good though
  • k

    Kumpelinus

    08/26/2025, 11:03 PM
    It is already 1am again 💀