Morning! Just noticed this PR https://github.com/supabase/supabase-js/pull/252

Am I missing something or it is indeed supposed to not access localStorage unless methods are actually used?

Was gonna start working on a lazy access approach to prevent client totally breaking if it doesn’t have access to localStorage even if you don’t use Supabase (but you’ll still have imported).

Then I noticed the PR and got excited - it doesn’t seem to do that though.

Am I missing the point of the PR?

Note: I might’ve just missed something in my codebase that actually initializes the client and the PR actually does what it says it does, but wanted to see if anyone had any thoughts on it before I started my day

Okay skimming through my repo on the phone guess I found the obvious culprit - exporting an instance of the client from

createClient

so I am actually initializing it even if not needed