https://www.dendron.so/ logo
Join Discord
Powered by
does github Actions maybe have a problem in Genera...
# questions
s
does github Actions maybe have a problem in General?
s
I was having problems earlier where my github actions just would not work at all, it might be on Github's end maybe? I think the actions are going through now
s
Yeah, this looks like GitHub problems, as that is just the first step of setting the container up
Set up job should take like a second, or only a few seconds
The entire build in our template for GitHub Actions takes like 3 minutes total out-of-box, initially
@User I saw you mentioned this error:
Copy code
error {"stack":"TypeError: value.replace is not a function\n    at encode (/home/runner/work/mettcon.github.io/mettcon.github.io/node_modules/stringify-entities/lib/core.js:7:17)\
- Is this still happening? - You said this happens at the export step?
s
I try to restart now
looks like it
stuck at 
Export notes
. Same error
s
- Do you get this same error if trying to build this locally (if you are able to build locally)? - Is this with latest version of Dendron? For more troubleshooting: - Run 
Dendron: Doctor
-> 
fixFrontmatter
- Did this modify files? If so, does it look like the fix(es) may help it work? - Is this a repo made from our existing GitHub Actions example template on GitHub? And if so, how long ago did you generate from the template?
And is this a public repo? If so, can I get a link? 🙂
s
How do I build locally?
And no It's not from the example
Yes... Latest version of dendron
s
I'll do some tests quick, see if I can figure it out
Okay, I believe I found it, going to verify
@User I'm going to raise a bug for 
Dendron: Doctor
, as this looks like an issue with how the 
title
property was being handled in one of your notes, and 
Dendron: Doctor
didn't catch it. In fact, 
Dendron: Doctor
seems to break it 😅 A scratch note was breaking it because the scratch note didn't have the 
title
value in quotes. This is needed if the value is just a number. Creating new scratch notes should automatically wrap that in quotes, not sure why it isn't present. For the time being, don't run 
Dendron: Doctor
. Try accepting this PR and seeing if it builds: https://github.com/Mettcon/mettcon.github.io/pull/1
@User This looks to be a 
Dendron: Doctor
problem. I'll raise an issue unless it may be known or documented elsewhere
Ah, I found it: The bug seems to be that Dendron doesn't know what to do with a note's title if it starts with a zero (
0
). It treats them as the start of a string that doesn't need quotes when a new note is made, and 
Dendron: Doctor
seems to even remove quotes from it if you add them
fixFrontmatter
seems to act very weird when file starts with a zero 😅 Makes strange renames to titles, for example
(I've added to the issue discussion with this extra info)
s
It sounds like the problem is more that we should make sure the note titles are always parsed as a string. Or we should validate the prop types and show warnings in the editor (like the frontmatter missing warning).
s
@User I'm heading off for the night, but if you can accept and merge the PR I sent, that should be enough to fix your publishing. If it doesn't quite work, I can revisit tomorrow 🙂
s
I managed to merge it. ðŸĪŠ but it works now
reading your changes. Your question was not about the used dendron version in vscode? what should I do to bump whatever version in that chain?
is dendron-cli Feature complete?
s
It has most features that the plugin does, but there might be some features that are plugin only. Is it missing something you need?
s
Oh.. I wanted to write that in chat. But no. I'm still working on installation
4 Views
PreviousNext
Powered by