https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • r

    rlh1994

    08/15/2022, 10:03 AM
    Dunn question - how big is dendron if I clone and install all the node modules?
  • r

    rlh1994

    08/15/2022, 10:49 AM
    Also has anyone built dendron on windows lately - I can't seem to get the Viz package to build in
    yarn setup
    - I get an error about
    cp
    not being a valid command, I'm not sure that
    cross-env
    has a cp command?
  • r

    rlh1994

    08/15/2022, 3:20 PM
    Is there a reason for using a non-whitespace negative look behind instead of a whitespace positive look behind here? https://github.com/dendronhq/dendron/blob/6366bff061a64514863b23bd9234fcef1c641bbb/packages/engine-server/src/markdown/remark/userTags.ts#L32
  • k

    kevins8

    08/15/2022, 3:22 PM
    no good reason that i can remember, tagging @SeriousBug in case he has more to add
  • s

    SeriousBug

    08/15/2022, 3:24 PM
    A whitespace positive lookbehind wouldn't work if it's at the start of the line I think
  • s

    SeriousBug

    08/15/2022, 3:25 PM
    I'm not sure if you could do (^|\s) though, that might work
  • r

    rlh1994

    08/15/2022, 3:26 PM
    Basically I'm trying to add more things that can be before (bracket opens, commas, etc) but I think it has to be either a positive or a negative listing everything BUT those characters (and whitespace)
  • r

    rlh1994

    08/15/2022, 3:27 PM
    I'll test it out in dendron, I managed to get it installed and compiling now so I'll see what what and what breaks
  • r

    rlh1994

    08/15/2022, 3:27 PM
    Just wanted to make sure there wasn't a specific reason I was unaware f
  • k

    kevins8

    08/15/2022, 3:29 PM
    i think if you take into account start of line, you should be able to switch it around
  • k

    kevins8

    08/15/2022, 3:29 PM
    this is an issue on our end. we should convert this to a js script to make it compatible. let me know if you get to it, otherwise i can take care of it
  • k

    kevins8

    08/15/2022, 3:30 PM
    stupidly big right now. ~2.2gb
  • r

    rlh1994

    08/15/2022, 3:31 PM
    Yeah there's two regexs here anyway I need to understand anyway, one for start of line and one not. I'm sure I'll ask more once I have a proper read through!
  • r

    rlh1994

    08/15/2022, 3:33 PM
    So I think this fix should work on unix, but it at least makes it work on windows. Line 30 of the package.json for dendron-viz should become
    "copyNonTSFiles": "(node ./ensureDir && cp ./src/loadModule.js lib/) || (node .\\ensureDir && copy .\\src\\loadModule.js lib\\)",
  • r

    rlh1994

    08/15/2022, 3:33 PM
    in theory it should only hit the windows part when the unix part fails...
  • r

    rlh1994

    08/16/2022, 9:04 AM
    āœ… Regex āŒ Understand how to add and able to run tests Honestly overly ambitious to assume I could do this with 0 js/ts experience šŸ˜…
  • a

    Aadam

    08/28/2022, 1:05 AM
    Where should I start if I want to understand the dendron codebase? I want to create a better plugin for Excalidraw support in Dendron.
  • k

    kevins8

    08/28/2022, 4:50 PM
    This has everything you need to get started with plugin development: [Plugin Core](https://docs.dendron.so/notes/87d90002-f480-45eb-a8c4-d00df4d61557) This is details about our development process: [Development Process](https://docs.dendron.so/notes/7aFrHnTNespaRzhlTwftM) If there is a specific integratino you want to go for, let me know and I can also give pointers. Something you might be interested in: we have a rfc to provide better integration with non-note files (aka everything else). we haven't begun the work here yet but long term, it would probably be the most natural integration for alternative formats like Excalidraw [38 - Links to files that are not notes](https://docs.dendron.so/notes/WCZ1LzhM07Om3KFPERk6l)
  • a

    Aadam

    08/28/2022, 4:55 PM
    Many thanks. I'll look into those, and will let you know if I have any questions 😃
  • d

    d1onys1us

    09/13/2022, 2:54 AM
    very interested in this! excalidraw is awesome!
  • c

    cameron

    09/27/2022, 10:48 PM
    šŸ‘‹ Have there been any past investigations into upgrading the version of yarn used by Dendron (from 1.x)? Aside from the benefits outlined in the launch posts for v2 (https://dev.to/arcanis/introducing-yarn-2-4eh1 ) and v3 (https://dev.to/arcanis/yarn-3-0-performances-esbuild-better-patches-e07 ), 1.x isn't getting patched these days, so the upgrade may be necessary in the future.
  • k

    kevins8

    09/27/2022, 11:19 PM
    we've tried a while back and ran into some breaking changes with pnp. we might invest in this again later this year
  • c

    cameron

    09/28/2022, 2:22 AM
    ah - FWIW, you can still get much of the dev ergonomics without enabling PnP ( https://yarnpkg.com/getting-started/migration#step-by-step ), that part isn't required to upgrade (although you could still run into other migration issues like realizing some libraries have dependencies that are ambiguous about what version they want, and you'll have to specify them rather than letting the legacy resolver pick something unpredictably)
  • k

    kevins8

    09/28/2022, 2:23 AM
    yep - i saw that. i think its definitely feasible for us to migrate, just a matter of bandwidth šŸ˜…
  • t

    tsnieman

    09/28/2022, 4:09 PM
    Is anyone aware of a Dendron + Neovim LSP project?
    k
    n
    • 3
    • 6
  • n

    nickolay-kond

    10/13/2022, 1:43 AM
    Publishing appears to be broken: https://github.com/dendronhq/dendron/issues/3665
  • k

    kevins8

    10/13/2022, 3:04 AM
    left a response
  • n

    nickolay-kond

    10/13/2022, 3:19 AM
    Left a response
  • k

    kevins8

    10/13/2022, 3:31 AM
    ditto
  • j

    jeep

    10/15/2022, 3:34 PM
    Does anyone have any ideas on how I can get past these errors and start building dendron? I started with these instructions: https://docs.dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa/ But when I get to
    yarn setup
    I wind up with errors. First this: https://gist.github.com/jeep/544b0b5a01c5e5ed6d07850352567508 then when I take out the network timeout I get this: https://gist.github.com/jeep/3e4a3089a3d684552eb13807c51fc0a3
    Copy code
    jeep@DESKTOP-JOE:~/dev/dendron$ node --version
    v16.17.1
    jeep@DESKTOP-JOE:~/dev/dendron$ yarn --version
    1.22.19
    jeep@DESKTOP-JOE:~/dev/dendron$ lerna --version
    5.6.2
    jeep@DESKTOP-JOE:~/dev/dendron$ cat /etc/os-release | grep PRETTY_NAME
    PRETTY_NAME="Ubuntu 22.04.1 LTS"
1...104105106107108Latest